Extend list_issues tests to cover Date/Number/Text field value variants

Author: kelsey-myers

pkg/github/issues_test.go

@@ -1091,7 +1091,23 @@ func Test_ListIssues(t *testing.T) {
 				"totalCount": 3,
 			},
 			"issueFieldValues": map[string]any{
-				"nodes": []map[string]any{},
+				"nodes": []map[string]any{
+					{
+						"__typename": "IssueFieldDateValue",
+						"field":      map[string]any{"name": "due"},
+						"value":      "2026-06-01",
+					},
+					{
+						"__typename":  "IssueFieldNumberValue",
+						"field":       map[string]any{"name": "estimate"},
+						"valueNumber": 2.5,
+					},
+					{
+						"__typename": "IssueFieldTextValue",
+						"field":      map[string]any{"name": "notes"},
+						"value":      "needs triage",
+					},
+				},
 			},
 		},
 	}
@@ -1364,11 +1380,19 @@ func Test_ListIssues(t *testing.T) {
 					assert.NotEmpty(t, label, "Label should be a non-empty string")
 				}
 
-				// Field values should be flattened to {field, value} pairs. Issue #123 in the mock
-				// data has a SingleSelectValue for "priority"; all others have an empty list.
-				if issue.Number == 123 {
+				// Field values should be flattened to {field, value} pairs. Issue #123 has a
+				// SingleSelectValue; issue #456 exercises the Date/Number/Text branches
+				// (including float formatting); #789 has no field values.
+				switch issue.Number {
+				case 123:
 					assert.Equal(t, []MinimalIssueFieldValue{{Field: "priority", Value: "P1"}}, issue.FieldValues)
-				} else {
+				case 456:
+					assert.Equal(t, []MinimalIssueFieldValue{
+						{Field: "due", Value: "2026-06-01"},
+						{Field: "estimate", Value: "2.5"},
+						{Field: "notes", Value: "needs triage"},
+					}, issue.FieldValues)
+				default:
 					assert.Empty(t, issue.FieldValues)
 				}
 			}

script/mcp-local

@@ -0,0 +1,6 @@
+#!/usr/bin/env bash
+# Wrapper for the locally-built github-mcp-server binary that injects a PAT from `gh auth token`.
+# Used by .vscode/mcp.json so VS Code's MCP client can spawn the local build with stdio transport.
+
+export GITHUB_PERSONAL_ACCESS_TOKEN="$(gh auth token)"
+exec /workspaces/github-mcp-server/github-mcp-server stdio "$@"

tmp/pr-description.md

@@ -0,0 +1,57 @@
+## Summary
+Adds Issues 2.0 custom field values (Priority, Visibility, Impact, etc.) to each issue returned by `list_issues`, exposed on `MinimalIssue` as `field_values: [{field, value}]`.
+
+## Why
+Issues 2.0 introduced custom fields (single-select, number, text, date) that are core to how teams triage and prioritise. Without them in the MCP response, an agent can list issues but has no way to see — or reason about — the values teams actually filter and sort by in the GitHub UI.
+
+Fixes #
+
+## What changed
+- `IssueFragment` now selects `issueFieldValues(first: 25)` (matches monolith `IssueField::ORGANIZATION_ISSUE_FIELDS_LIMIT`).
+- New `IssueFieldRef` type with a `Name()` method, resolving the field name across the 4-variant `IssueFields` union.
+- New `IssueFieldValueFragment` union fragment over `IssueFieldDate|Number|SingleSelect|Text Value`.
+- `MinimalIssue` gains `FieldValues []MinimalIssueFieldValue` (`omitempty`); each entry carries `field`, `value`, and a forward-compat `values []string` for the upcoming `IssueFieldMultiSelectValue` (see github/github#430793).
+- `fragmentToMinimalIssueFieldValue` converts the fragment to the minimal shape.
+- Tests cover both label-filtered and non-label-filtered query variants.
+
+### Live validation
+Smoke-tested against production github.com via a local build of this server, against `github/issues`:
+
+```json
+{ "number": 21640, "field_values": [
+  {"field":"Priority","value":"P2"},
+  {"field":"Visibility","value":"Medium"},
+  {"field":"Impact","value":"Medium"},
+  {"field":"Effort","value":"Medium"}
+]}
+```
+
+## MCP impact
+- [ ] No tool or API changes
+- [x] Tool schema or behavior changed
+   - `list_issues` response now includes an optional `field_values` array per issue. Additive only, omitted for issues without custom field values, so existing consumers aren't broken.
+- [ ] New tool added
+
+## Prompts tested (tool changes only)
+- "List the open issues in `github/issues` and tell me which ones are P1." — agent can now answer from the response without follow-up tool calls.
+- "What's the priority breakdown of open issues in `github/issues`?"
+
+## Security / limits
+- [ ] No security or limits impact
+- [ ] Auth / permissions considered
+- [x] Data exposure, filtering, or token/size limits considered
+   - `first: 25` caps the per-issue field array at the same limit the dotcom monolith enforces (`ORGANIZATION_ISSUE_FIELDS_LIMIT`). No new auth surface — the values are scoped to the same `repo` permission the existing query already requires.
+
+## Tool renaming
+- [ ] I am renaming tools as part of this PR (e.g. a part of a consolidation effort)
+   - [ ] I have added the new tool aliases in `deprecated_tool_aliases.go`
+- [x] I am not renaming tools as part of this PR
+
+## Lint & tests
+- [x] Linted locally with `./script/lint`
+- [x] Tested locally with `./script/test`
+
+## Docs
+- [x] Not needed
+   - Schema is auto-generated from tool definitions; no README changes required for an additive response field.
+- [ ] Updated (README / docs / examples)