Remove unused runtime_config_t::m_prop_keys and m_prop_values

[elinor-fung]

Removed unused property key and value vectors.

[Copilot]

Pull request overview

This PR removes two unused private vectors from runtime_config_t, reducing unused state in the corehost runtime configuration type.

Changes:

• Removed m_prop_keys and m_prop_values from runtime_config_t.
• Verified no remaining references to these members in src/native/corehost or the repository search scope.

Show a summary per file

File	Description
src/native/corehost/runtime_config.h	Removes unused private property key/value vector fields from runtime_config_t.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[github-actions]

Caution

Security scanning requires review for Code Review

Details

The threat detection results could not be parsed. The workflow output should be reviewed before merging.

Review the workflow run logs for details.

🤖 Copilot Code Review — PR #128268

Note

This review was generated by Copilot.

Holistic Assessment

Motivation: The PR removes two unused member variables (m_prop_keys and m_prop_values) from runtime_config_t. Dead code removal is always justified — it reduces cognitive load and eliminates potential confusion about the class's responsibilities.

Approach: Direct deletion of the unused fields. This is the simplest and only correct approach.

Summary: ✅ LGTM. Trivial dead code cleanup. Grep across the entire src/native/corehost/ tree confirms these fields have zero references (no reads, writes, or address-of). The removal is safe and correct.

---

Detailed Findings

✅ Correctness — Fields are genuinely unused

Searched for m_prop_keys and m_prop_values across all of src/native/corehost/ and found zero references outside the removed declarations. No code reads, writes, or takes the address of these fields. Removal has no behavioral impact.

✅ Scope — Minimal, focused change

The PR touches exactly one file and removes exactly two lines. No risk of unintended side effects.

Generated by Code Review for issue #128268 · ● 1.6M · ◷