feat: integrate Atlas Cloud provider#1672
Open
lucaszhu-hue wants to merge 1 commit into
Open
Conversation
lucaszhu-hue
temporarily deployed
to
security-review
GitHub Actions
Inactive
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Environment variable for AI API key. | ||
| aiAPIKeyEnv = "GOSEC_AI_API_KEY" // #nosec G101 | ||
| aiAPIKeyEnv = "GOSEC_AI_API_KEY" // #nosec G101 | ||
| atlasAPIKeyEnv = "ATLASCLOUD_API_KEY" |
ccojocar
requested changes
May 15, 2026
|
|
||
| const ( | ||
| AIProviderFlagHelp = `AI API provider to generate auto fixes to issues. Valid options are: | ||
| - atlas (Atlas Cloud default), atlas-deepseek-v4-flash, atlas-qwen3-coder-next, atlas-kimi-k2.6, atlas/<model-id>, atlas:<model-id>; |
Member
There was a problem hiding this comment.
Is this a valid syntax to reference the name of any model atlas/<model-id>?
| import "strings" | ||
|
|
||
| const ( | ||
| ModelAtlasDefault = "deepseek-ai/deepseek-v4-flash" |
Member
There was a problem hiding this comment.
Are these consts outside of this package? If not, I would use private names with lower cases.
| // Environment variable for AI API key. | ||
| aiAPIKeyEnv = "GOSEC_AI_API_KEY" // #nosec G101 | ||
| aiAPIKeyEnv = "GOSEC_AI_API_KEY" // #nosec G101 | ||
| atlasAPIKeyEnv = "ATLASCLOUD_API_KEY" |
Member
There was a problem hiding this comment.
Why these env variables required? I would just used the generic GOSEC_AI_API_KEY and make introduce something like GOSEC_AI_PROVIDER and you can set it to the specific provider like in this example atlas.
I would like to keep the name of these environment variables generic. Thanks
| @@ -0,0 +1,5 @@ | |||
| GOSEC_AI_API_KEY=your_atlas_cloud_api_key | |||
| ATLASCLOUD_API_KEY=your_atlas_cloud_api_key | |||
Member
There was a problem hiding this comment.
I would remove this env variable. It seems duplicate to me. They need to be generic and provider agnostic.
| @@ -0,0 +1,42 @@ | |||
| # Atlas Cloud Provider Review | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Atlas Cloud provider and docs.